myBrickset Android App

RikTheVeggie

The API is working but the format of the data coming back has changed.  I'm sure this was an unintentional slip-up and it'll hopefully be fixed ASAP (after some gentle prodding).

RikTheVeggie

Everything should be back to normal now, please LMK if you continue to experience issues.  I shall look at reworking the code so similar interruptions won't cause sets to disappear and myBrickset will instead continue to use cached data.

NickF22

^ Yes seems to be ok now. Thanks for fixing so quickly.

Legogram

Thanks, mine seems good too!  I was really lost without it.

SumoLego

All fixed!  @RikTheVeggie is awesome as always!

RikTheVeggie

I can't take any credit for this one, @Huw fixed it this time!

Huw

After having broken it in the first place!

MaffyD

^ I reckon you could've got away without that admission Huw! :-)

deusxanime

Something new broken or just me? Was showing no sets owned or wanted. I tried Log Off and back on again. It seems to accept the login but never updates the app with my sets. If I leave and come back, it gives me a message about password changing or expired, but my pwd works fine on brickset.com. Previously it has worked great, not sure why it suddenly started doing this. Using myBrickset 2.5.5 on a Pixel with Android 7.1.1.

NickF22

^ Same for me ; seems to be the same symptoms as last time - changed API @Huw ?

Huw

No, nothing has changed this end and if I test the API then everything appears to be working correctly.

I've been in touch with @RikTheVeggie but at the moment can't offer any further clues as to why it's stopped working.

RikTheVeggie

Things were fine for everyone until yesterday?  So the latest update has been working for a week before things went wrong?  (just want to definitively rule out a coding issue).

It sounds like Huw and I are getting different results from the API as it's still not working for me, or maybe there's an intermittent issue which is why it looked fine when Huw tested it.

I have to run off to work unfortunately but I'll try to monitor mail etc as much as possible, and will jump back into investigations tonight if the issue continues to persist.

Huw

I believe it's working again now: I've just refreshed the codebase with the latest from by dev. machine.

The server was rebooted yesterday and while that shouldn't have caused any problems I can't think of a better explanation.

NickF22

^ Agreed, working now. Don't you hate it when that happens and there's no obvious cause?

RikTheVeggie

Thanks for the fast fix @Huw and for confirming everything's good @NickF22.  I can now relax and "enjoy" my day at work!

deusxanime

Just got a chance to try it out again today and does appear to be working now. Maybe I just happened to try to use it when the server was rebooting? Or some other oddness? Anyway, I'll report back if stops working again, but for now appears to be good.

Note: Actually while verifying I noticed that myBrickset says I have 292 sets owned, but Brickset.com shows 356. Do they count differently? Wondering if .com number includes duplicates while the android app only counts unique sets?

RikTheVeggie

@deusxanime Thanks for testing and reporting everything's good.  

myBrickset reports on both the total number of sets owned (including multiples) and the number of unique sets - eg 824 (510 unique).  These numbers should agree with what's shown on http://brickset.com/mycollection.

The piece count is different to brickset.com, this may be a bug - myBrickset might not be counting pieces for multiple counts - I'd have to investigate a bit more.

deusxanime

I figured it out. When I open Sets > Owned, the number at the top is unique sets (292). When I go to the Summary instead it says I own 356 items, which matches what is displayed on top at brickset.com, with again (292 unique). So it is just a difference in how the number is calculated/presented. Thank for your work Rik!

RikTheVeggie

Groovy, glad there was an answer to the discrepancy!  Let me know if you think the information myBrickset displays could be any clearer - I have done what I think is the best, and this seems to follow brickset.com in most places.  eg, showing all owned sets in a list (http://brickset.com/sets/mycollection-owned) shows the 'unique' count, the same as myBrickset does.  Only when showing the summary are duplicates included.

I did discover a bug when looking at the Summary details - total owned value doesn't count duplicates.  So I'll fix that for the next release.

JudgeChuck

Hi @RikTheVeggie, one thing that I have noticed is that, when you go into "Sets" and then either "Owned" or "Wanted", the application doesn't save the state of the sections and all are expanded, while I would prefer them to be closed, so that I can more quickly scroll through all the themes, to view the one that I want to.

Other than that, thanks again for a great app! :-)

RikTheVeggie

@JudgeChuck I don't have an option to save the state of the Expandable List View atm (tho' it's something I could look at adding), but in Settings there's an option "Auto-Expand Expandable List View".  If you untick that then it'll stop the groups automatically expanding when you view the results.

To be honest I'm still not keen on the implementation of that view either (and never use it myself so I tend to forget about it), but aren't sure what to do to improve it yet.

JudgeChuck

Doh! Thanks for pointing that out... It works fine for me.

:-)

RikTheVeggie

Good timing actually, it was an option I added quite recently - glad it was useful :)

RikTheVeggie

brickset's switch over to https seems to have caused a few connection issues, I'll get a fix out asap.

juno_2023

Thanks so much for the proactive support of the app. It's awesome to see the transparency of its development and maintenance.

It certainly doesn't hurt that the app itself is pretty awesome too. :-) Thanks for all you do!

RikTheVeggie

The fix has been pushed and should begin rolling out to devices shortly.
I've given it a thorough test but please let me know if you notice any issues.

MattDawson

My apps just updated! :3

NickF22

Thanks for fixing so quickly! The obvious things that were wrong for me (images and instructions) are working now.

nwr122

@RikTheVeggie, I've installed the latest version on a Oneplus 3T, but it refuses to login, error message is Unable to login(network error?), please retry....tried on both wifi and mobile data same error.

Was working fine on my Z3...is this something to do with the https update?

Great app, keep up the good work :-)

NickF22

Low priority, but is it possible to "clean up" the drop down list of Themes? There's some in there that have been superseded, eg Angry Birds -> The Lego Angry Birds Movie, Scooby Doo -> Scooby-Doo.

Or does it build the list from all the themes that have ever existed on Brickset?

PS I second the thanks, probably the most used app on my phone...

Huw

There were some obsolete themes in the list at Brickset so I've removed them which might cause them to disappear from the app too.

RikTheVeggie

@nwr122 - it was working with my debug build but I've just installed the latest release and have been able to recreate the error (I'm sure I'd tested this tho'!).  It looks like I must've missed something when writing the update.  I am SOOO sorry and will look to get a fix out ASAP (but I've still got another couple of hours at work first before I can head home to take a look).

@NickF22 - this list is built on the fly from brickset.com (it normalises the data into a separate table), I've never considered that it could end up with obsolete data in.  I'll take a look, it should be reasonably easy to clean it up.

RikTheVeggie

@nwr122 - no idea how that bug got past me but the fix should be live in the Play Store shortly (depends on your region, it's showing for me already), everything should work fine this time..

sid3windr

I also noticed "Disney Princesses > Palace Pets" being empty yesterday while the sets were in "Disney > Palace Pets" - I trust that'll be cleaned up with the theme thing above :-)

RikTheVeggie

@NickF22 & @sid3windr - I'm working on cleaning up themes & subthemes when the app starts (not a perfect solution to the problem but a good start) and have something that seems to work.  Would you mind sending me a copy of your db (main screen | menu | send log file | include db) so that I can test on "real world" data and ensure I haven't broken anything?  Thanks!

VorpalRyu

Noticing a few sets are getting duplicated, seem to be older data, no pictures, if I own it, not flagged as owned (but the newer one is tagged correctly, same for wanted) & in some cases no name either. Some of the offenders I can remember:

76078-1 Hulk vs. Red Hulk - the duplicate has {?} in the name field (not marked as owned)

71348-1 Hermione Granger - the duplicate is named Hermione (not marked as wanted)

60143-1 Auto Transport Heist - the duplicate has {?} in the name field 

nwr122

RikTheVeggie said:

@nwr122 - no idea how that bug got past me but the fix should be live in the Play Store shortly (depends on your region, it's showing for me already), everything should work fine this time..

@RikTheVeggie, brilliant, all sorted, many thanks for the quick response and keep up the good work 

sid3windr

@RikTheVeggie e-mail on the way!

NickF22

@RikTheVeggie ditto!

RikTheVeggie

@sid3windr & @NickF22 - thank you kindly, mails received and I'll use them to ensure everything looks good.

@nwr122 - excellent, thanks for confirming.  And welcome to the forum!

@VorpalRyu - hmm, I think you're seeing "place holder" data from before the set name was known.  Sometimes the underlying id in the data that Huw provides changes, but myBrickset should be able to handle that ok.   Would you mind sending me a copy of your db too so I can confirm the issue and prove that any fix I come up with resolves it?

VorpalRyu

Is the db contained in OBB files? Cause I couldn't find anything else that wasn't an image file... If so, they're on their way to you.

VorpalRyu

Okay, so apparently they're to big to add as an attachment... The main file is 238 mb in size...

NickF22

^ Follow @RikTheVeggie 's instructions a few posts up. (main screen | menu | send log file | include db) 

RikTheVeggie

Oops, sorry @VorpalRyu!  See here for instructions: http://bricksetforum.com/discussion/comment/513036/#Comment_513036

VorpalRyu

Done, should have an email inbound.

RikTheVeggie

@sid3windr, @NickF22, @VorpalRyu

Here you go folks, this should resolve all of the issues you reported.  I never realised so much obsolete data was able to build up - using one of the sample dbs you provided, myBrickset was able to remove 264 sets, 8 themes and 250 subthemes!  This cleanup is now automated and should stop the issue from occurring again in the future.

You can grab a copy here: otissoft.co.uk/mybrickset/bin/myBrickset-2.5.8.apk (4.3MB).  I'll push it out to the play store in a couple of days once you've confirmed it seems to be working as expected.

NickF22

^Magic, thanks for the quick turnaround.  I've installed and had a very quick try, and the lists are cleaned up as expected. I've not fully road tested it though, will use as normal over the next couple of days and let you know if I spot anything.

sid3windr

Cleaned up here as well, but I also did not look very far. Will let you know if I see anything out of the ordinary. Thanks!

NickF22

It's behaved for me since I installed.

RikTheVeggie

Thanks for the update @NickF22.  Everything seemed good in my tests and I assumed no news was good news so pushed out the update globally.